mimic: ceph-volume: does not recognize wal/db partitions created by ceph-disk #29463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 2, 2019 11:40
This adds a parameterized fixture as input to the tests. Should make writing new tests easier since only fixture parameters need to be added. In the future we should be able to reuse the fixtures to build other fixtures and reuse the parametrization. Signed-off-by: Jan Fajerski <jfajerski@suse.com> (cherry picked from commit f42287c)
It seems like ceph-disk sometimes creates OSDs where the wal and db partitions have no PARTLABEL set. This commit alters tests so that the empty string is considered a valid label. Signed-off-by: Jan Fajerski <jfajerski@suse.com> (cherry picked from commit bb29110)
In some cases ceph-disk does not populate PARTLABEL for wal and db partitions. This commit adds the assumption that the empty string is a valid label and falls back to identifying those disks by PARTTYPE. Fixes: https://tracker.ceph.com/issues/40917 Signed-off-by: Jan Fajerski <jfajerski@suse.com> (cherry picked from commit 82d2ae7)
alfredodeza
approved these changes
Aug 5, 2019
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/41056